refactoring runmat-config for maintainability#329
Open
nallana wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Mostly a mechanical refactor that moves existing config schema/loader code into dedicated modules and adds tests to guard behavior; risk is limited to potential regressions in re-exports or module visibility affecting downstream crates.
Overview
Refactors
runmat-configby splitting the largelib.rsinto aschema/module tree (typed config structs/enums/defaults plusaccelerateruntime conversions) and aloader/module tree (file discovery, file parsing/serialization, env var overrides, and parsing helpers), while keeping the public API surfaced via re-exports inlib.rs.Moves previously inline unit tests into focused integration tests under
crates/runmat-config/tests/(defaults, serialization, file loading, env override behavior, andacceleratebridge), and updatesdocs/CONFIG.mdto reference the newschema/location.Reviewed by Cursor Bugbot for commit 6e00bf5. Bugbot is set up for automated code reviews on this repo. Configure here.