Skip to content

Commit 9d4b36b

Browse files
committed
fix: pass Docker tag variables as env vars instead of build args
RELEASE_VERSION, DOCKERHUB_REPO, and DOCKERHUB_IMG are HCL variables used in docker-bake.hcl tag templates. Passing them via *.args.* only sets Docker build args, not HCL variables, so the tags defaulted to "latest" instead of the actual version.
1 parent 2846933 commit 9d4b36b

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"worker-comfyui": patch
3+
---
4+
5+
fix: pass RELEASE_VERSION as environment variable so docker-bake.hcl resolves versioned tags instead of defaulting to "latest"

.github/workflows/release.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,13 +112,14 @@ jobs:
112112

113113
- name: Build and push ${{ matrix.target }}
114114
uses: docker/bake-action@v2
115+
env:
116+
DOCKERHUB_REPO: ${{ vars.DOCKERHUB_REPO }}
117+
DOCKERHUB_IMG: ${{ vars.DOCKERHUB_IMG }}
118+
RELEASE_VERSION: ${{ needs.release.outputs.version }}
115119
with:
116120
targets: ${{ matrix.target }}
117121
push: true
118122
set: |
119-
*.args.DOCKERHUB_REPO=${{ vars.DOCKERHUB_REPO }}
120-
*.args.DOCKERHUB_IMG=${{ vars.DOCKERHUB_IMG }}
121-
*.args.RELEASE_VERSION=${{ needs.release.outputs.version }}
122123
*.args.HUGGINGFACE_ACCESS_TOKEN=${{ secrets.HUGGINGFACE_ACCESS_TOKEN }}
123124
124125
post-release:

0 commit comments

Comments
 (0)