Merge branch 'main' into vivien

Author: vivienhenz24

runpod/api/ctl_commands.py

@@ -88,7 +88,7 @@ def get_pod(pod_id: str):
 
 def create_pod(
     name: str,
-    image_name: str,
+    image_name: Optional[str] = "",
     gpu_type_id: Optional[str] = None,
     cloud_type: str = "ALL",
     support_public_ip: bool = True,
@@ -143,6 +143,10 @@ def create_pod(
     >>> pod_id = runpod.create_pod("test", "runpod/stack", instance_id="cpu3c-2-4")
     """
     # Input Validation
+
+    if not image_name and not template_id:
+        raise ValueError("Either image_name or template_id must be provided")
+
     if gpu_type_id is not None:
         get_gpu(gpu_type_id)  # Check if GPU exists, will raise ValueError if not.
     if cloud_type not in ["ALL", "COMMUNITY", "SECURE"]:

tests/test_api/test_ctl_commands.py

@@ -206,6 +206,26 @@ def test_create_pod_with_encrypt_volume(self):
             called_mutation = patch_request.call_args[1]['data']
             self.assertNotIn("encryptVolume", called_mutation)
 
+    def test_create_pod_missing_image_and_template(self):
+        """
+        Tests create_pod error if neither image_name nor template_id are provided
+        """
+        with patch("runpod.api.graphql.requests.post"), patch(
+            "runpod.api.ctl_commands.get_gpu"
+        ), patch("runpod.api.ctl_commands.get_user"):
+            with self.assertRaises(ValueError) as context:
+                ctl_commands.create_pod(
+                    name="POD_NAME",
+                    gpu_type_id="NVIDIA A100 80GB PCIe",
+                    network_volume_id="NETWORK_VOLUME_ID",
+                )
+
+            self.assertEqual(
+                str(context.exception),
+                "Either image_name or template_id must be provided",
+            )
+            
+            
     def test_stop_pod(self):
         """
         Test stop_pod