Skip to content

Commit 766807b

Browse files
committed
fix(fitness): resolve CodeQL code quality issues
- Remove unused 'inspect' import from rp_gpu_fitness.py - Remove unused 'call' import from test files (test_fitness.py, test_gpu_fitness.py, test_system_fitness.py) - Add explanatory comment to empty except clause in rp_gpu_fitness.py All 83 fitness check tests pass with these changes.
1 parent 3c69761 commit 766807b

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

runpod/serverless/modules/rp_gpu_fitness.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"""
1010

1111
import asyncio
12-
import inspect
1312
import os
1413
import subprocess
1514
from pathlib import Path
@@ -310,6 +309,7 @@ def auto_register_gpu_check() -> None:
310309
except (FileNotFoundError, subprocess.TimeoutExpired):
311310
has_gpu = False
312311
except Exception:
312+
# Catch any other exceptions and assume no GPU
313313
has_gpu = False
314314

315315
if has_gpu:

tests/test_serverless/test_modules/test_fitness.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import asyncio
1010
import os
1111
import pytest
12-
from unittest.mock import patch, MagicMock, call
12+
from unittest.mock import patch, MagicMock
1313

1414
from runpod.serverless.modules.rp_fitness import (
1515
register_fitness_check,

tests/test_serverless/test_modules/test_gpu_fitness.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import subprocess
1111
import pytest
1212
from pathlib import Path
13-
from unittest.mock import patch, MagicMock, AsyncMock, call
13+
from unittest.mock import patch, MagicMock, AsyncMock
1414

1515
from runpod.serverless.modules.rp_gpu_fitness import (
1616
_parse_gpu_test_output,

tests/test_serverless/test_modules/test_system_fitness.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import asyncio
99
import os
1010
import subprocess
11-
from unittest.mock import patch, MagicMock, AsyncMock, call
11+
from unittest.mock import patch, MagicMock, AsyncMock
1212

1313
import pytest
1414

0 commit comments

Comments
 (0)