Skip to content

Commit bd1d464

Browse files
committed
fix(tests): update CUDA tests to match implementation
The test assertions were expecting the old API (shell=True) but the implementation was changed to use a list and stderr=subprocess.DEVNULL. Updated test assertions to match the actual implementation.
1 parent 6c02a98 commit bd1d464

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

tests/test_serverless/test_utils/test_cuda.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
Unit tests for the rp_cuda module
33
"""
44

5+
import subprocess
56
from unittest.mock import patch
67

78
from runpod.serverless.utils import rp_cuda
@@ -15,7 +16,7 @@ def test_is_available_true():
1516
"subprocess.check_output", return_value=b"NVIDIA-SMI"
1617
) as mock_check_output:
1718
assert rp_cuda.is_available() is True
18-
mock_check_output.assert_called_once_with("nvidia-smi", shell=True)
19+
mock_check_output.assert_called_once_with(["nvidia-smi"], stderr=subprocess.DEVNULL)
1920

2021

2122
def test_is_available_false():
@@ -26,7 +27,7 @@ def test_is_available_false():
2627
"subprocess.check_output", return_value=b"Not a GPU output"
2728
) as mock_check_output:
2829
assert rp_cuda.is_available() is False
29-
mock_check_output.assert_called_once_with("nvidia-smi", shell=True)
30+
mock_check_output.assert_called_once_with(["nvidia-smi"], stderr=subprocess.DEVNULL)
3031

3132

3233
def test_is_available_exception():
@@ -37,4 +38,4 @@ def test_is_available_exception():
3738
"subprocess.check_output", side_effect=Exception("Bad Command")
3839
) as mock_check:
3940
assert rp_cuda.is_available() is False
40-
mock_check.assert_called_once_with("nvidia-smi", shell=True)
41+
mock_check.assert_called_once_with(["nvidia-smi"], stderr=subprocess.DEVNULL)

0 commit comments

Comments
 (0)