Skip to content

Handle parse errors#47

Open
jan4843 wants to merge 3 commits intoruntastic:masterfrom
jan4843:parse-error
Open

Handle parse errors#47
jan4843 wants to merge 3 commits intoruntastic:masterfrom
jan4843:parse-error

Conversation

@jan4843
Copy link
Copy Markdown

@jan4843 jan4843 commented Jun 24, 2020

Requests where the body is not valid JSON would cause MultiJson::ParseError to be raised but not translated to a RequestHandler error. Handling RequestHandler::ExternalBaseError should arguably include parsing errors caused by invalid user input.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 25, 2020

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.20%. Comparing base (80a6d77) to head (ab80ff4).
⚠️ Report is 15 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   98.19%   98.20%           
=======================================
  Files          41       41           
  Lines         887      889    +2     
=======================================
+ Hits          871      873    +2     
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants