Upstream symbolic bytes lookup, List membership lemmas#2702
Merged
automergerpr-permission-manager[bot] merged 6 commits intoAug 1, 2025
Conversation
palinatolmach
changed the title
bytes lookup lemmas for symbolic immutablesbytes lookup, List membership lemmas
lucasmt
reviewed
Jul 31, 2025
lucasmt
approved these changes
Jul 31, 2025
Contributor
lucasmt
left a comment
lucasmt
left a comment
There was a problem hiding this comment.
I'm approving the PR, just have one comment above that I think needs to be addressed before it's merged
Contributor
Author
|
I opened a PR in Kontrol to test if upstreamed lemmas don't negatively affect the tests and are applied if I take out the same lemmas from Kontrol aux files. The tests are passing: runtimeverification/kontrol#1059 (there's a minor expected output diff in some |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2476.
This PR adds lemmas for lookups in partially symbolic
bytesarrays; specifically, in runtime bytecode of contracts that containimmutablevariables that are initialized in a constructor with a symbolic value. It also addsListmembership lemmas that facilitate checking if a performed call is allowed in Kontrol when theallowCallscheatcode is used.Once this PR is merged, the relevant lemmas should be removed from
KONTROL-AUX-LEMMASand https://github.com/runtimeverification/kontrol/blob/master/src/tests/integration/test-data/symbolic-bytes-lemmas.k.