Update opcode summaries to standardize labels and improve clarity#2737
Merged
Conversation
tothtamas28
reviewed
Apr 8, 2025
Stevengre
force-pushed
the
better-summarization
branch
from
e45d3db to
2872076
Compare
tothtamas28
approved these changes
Apr 9, 2025
- Changed labels for various opcode summaries to follow a consistent naming convention, replacing instances of `-1` with `-NOGAS` or `-USEGAS` where applicable. - This update enhances readability and maintains uniformity across the summary definitions, ensuring better understanding and maintenance of the codebase.
… to unused variables and duplicate labels.
- Introduced helper functions to determine the presence of `USEGAS`, `BERLIN`, `LE0`, and `INVALID` rules, improving code clarity and maintainability. - Updated the `_transform_rule_id` function to utilize these new helper functions for better readability and streamlined logic. - Removed outdated transformation functions that were no longer necessary, enhancing overall code efficiency.
Stevengre
force-pushed
the
better-summarization
branch
from
2872076 to
8308c81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-1with-NOGASor-USEGASwhere applicable.