EIP-7685 - Refactor requests root generation#2758
Closed
anvacaru wants to merge 8 commits into
Closed
Conversation
Contributor
Author
|
Closing as these changes were incorporated in #2762 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in implementing EIP-7685 (General Purpose Execution Layer Requests) to conform to the reference implementations (process_general_purpose_requests).
Bytesobject. Therequest_typebyte is prepended before therequestRoothash is computed.DEPOSIT_REQUEST_TYPEfrom anIntto a Bytes constant for proper type consistency<depositRequest>cell to useBytesinstead ofListfor request storage.These changes ensure our KEVM implementation passes conformance tests and correctly implements both EIPs.
We will update the failing list of conformance tests after #2749 is merged.