Fix LIST.in hook for non-constructor-like list elements#4111
Merged
automergerpr-permission-manager[bot] merged 3 commits intoJun 16, 2025
Conversation
The previous list hook implementation `LIST.in` was testing membership based on _syntactic_ equality. This is incorrect if the elements of the list are not constructor-like (like variables or unevaluated function calls), `False` cannot be returned in those cases. When all known list elements are constructor-like, syntactic equality is sufficient. A unit test was added for this case.
Collaborator
Author
|
The symptom that led to discovering this bug was a kontrol end-to-end test: https://github.com/runtimeverification/kontrol/actions/runs/15538343867/job/43743019572?pr=1032#step:6:58 |
tothtamas28
approved these changes
Jun 16, 2025
automergerpr-permission-manager
Bot
deleted the
HOTFIX-list-membership-hook
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous list hook implementation
LIST.inwas testing membership based on syntactic equality. This is incorrect if the elements of the list are not constructor-like (like variables or unevaluated function calls),Falsecannot be returned in those cases. When all known list elements are constructor-like, syntactic equality is sufficient. A unit test was added for this case.