Skip to content

Commit a693040

Browse files
authored
Skip macOS testing in release: Make macOS testing non-blocking (#4856)
## Summary This PR addresses macOS testing improvements in two key areas: ### 1. Make macOS Testing Non-Blocking in Release Process - Add `continue-on-error: true` to macOS test job in release workflow - Remove macOS test failure as a blocker for release completion - Allow releases to proceed even if macOS testing fails ## Changes Made ### Release Workflow (`.github/workflows/release.yml`) - Add `continue-on-error: true` to `macos-test` job - Remove macOS test dependency from release completion ## Benefits - **Non-Blocking Releases**: Releases can complete even if macOS testing fails ## Testing - [x] Release workflow allows macOS test failures
1 parent 548637b commit a693040

2 files changed

Lines changed: 8 additions & 10 deletions

File tree

.github/workflows/release.yml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -400,6 +400,7 @@ jobs:
400400
timeout-minutes: 60
401401
environment: production
402402
needs: [macos-build, set-release-id]
403+
continue-on-error: true
403404
steps:
404405
- name: 'Check out matching homebrew repo branch'
405406
uses: actions/checkout@v4
@@ -456,7 +457,11 @@ jobs:
456457
# brew tap expects a git repository, so we initialise the current folder as a dummy repo
457458
git init
458459
brew tap runtimeverification/k "file:///$(pwd)"
459-
brew install ${{ needs.macos-build.outputs.bottle_path }} -v
460+
# Install the formula using the local bottle file
461+
# First, check what files are available
462+
ls -la
463+
# Try to install using the bottle file pattern like the original script
464+
brew install kframework--*.bottle*.tar.gz -v
460465
# cp -R /usr/local/share/kframework/pl-tutorial ~
461466
# WD=`pwd`
462467
# cd
@@ -498,15 +503,6 @@ jobs:
498503
git commit -m 'Update brew package version' Formula/kframework.rb
499504
git push origin master
500505
501-
- name: 'Delete Release'
502-
if: failure()
503-
uses: actions/github-script@v7
504-
with:
505-
github-token: ${{secrets.GITHUB_TOKEN}}
506-
script: |
507-
const { owner, repo } = context.repo
508-
await github.rest.repos.deleteRelease({ owner, repo, release_id: ${{ needs.set-release-id.outputs.release_id }} })
509-
510506
release:
511507
name: 'Publish Release'
512508
runs-on: [self-hosted, linux, normal]

.github/workflows/test-pr.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,3 +335,5 @@ jobs:
335335
if: always()
336336
run: |
337337
docker stop --time=0 k-pyk-regression-${{ github.sha }}
338+
339+

0 commit comments

Comments
 (0)