Skip to content

Skip macOS testing in release: Make macOS testing non-blocking#4856

Merged
F-WRunTime merged 8 commits intodevelopfrom
hotfix/mac-release-failure
Sep 13, 2025
Merged

Skip macOS testing in release: Make macOS testing non-blocking#4856
F-WRunTime merged 8 commits intodevelopfrom
hotfix/mac-release-failure

Conversation

@F-WRunTime
Copy link
Copy Markdown
Member

@F-WRunTime F-WRunTime commented Sep 11, 2025

Summary

This PR addresses macOS testing improvements in two key areas:

1. Make macOS Testing Non-Blocking in Release Process

  • Add continue-on-error: true to macOS test job in release workflow
  • Remove macOS test failure as a blocker for release completion
  • Allow releases to proceed even if macOS testing fails

Changes Made

Release Workflow (.github/workflows/release.yml)

  • Add continue-on-error: true to macos-test job
  • Remove macOS test dependency from release completion

Benefits

  • Non-Blocking Releases: Releases can complete even if macOS testing fails

Testing

  • Release workflow allows macOS test failures

- During release do not be dependent on MacOS Release
- Change from installing specific bottle filename to using wildcard pattern
- Add debugging output to see available files
- Use pattern matching like the original brew-install-bottle script
- This should resolve the 'No formulae or casks found' error

The issue was that brew install was trying to interpret the .tar.gz filename
as a formula name instead of installing the local bottle file.
@F-WRunTime F-WRunTime requested a review from a team as a code owner September 11, 2025 19:16
- Add test-macos-build job to catch macOS build issues during PR testing
- Mirror release workflow's macOS package building and testing logic
- Update all LLVM version references from 15 to 17 for consistency
- Prevent macOS build failures from only being discovered during release

This addresses the macOS build failure in the release workflow by adding
proactive testing in the PR workflow, ensuring issues are caught earlier
in the development cycle.
- Add test-macos-build job to catch macOS build issues during PR testing
- Mirror release workflow's macOS package building and testing logic
- Prevent macOS build failures from only being discovered during release

This addresses the macOS build failure in the release workflow by adding
proactive testing in the PR workflow, ensuring issues are caught earlier
in the development cycle.
…lation

- Replace bottle installation test with formula validation and source build
- Use brew audit to validate formula syntax
- Install from source instead of non-existent bottle files
- Create test tarball from current code if release tarball unavailable
- Update artifact upload to include formula file for debugging

This resolves the 'No formulae or casks found' error in PR testing by
testing the actual formula validation and source installation process
rather than trying to install non-existent bottle files.
- Remove brew tap step that was causing path mismatch error
- Use direct formula validation with brew audit
- Install directly from formula file instead of tapping repository
- Simplify approach to avoid git repository path conflicts

This resolves the 'Tap runtimeverification/k remote mismatch' error
by eliminating the problematic brew tap command entirely.
@rv-jenkins rv-jenkins changed the base branch from master to develop September 12, 2025 05:05
@F-WRunTime F-WRunTime changed the title Fix macOS bottle installation in GitHub Actions Add macOS testing to PR workflow and make release macOS testing non-blocking Sep 12, 2025
- Use 'brew tap --force-local' to add local formula as tap
- Use 'brew audit --strict kframework' with formula name instead of file path
- This resolves the 'Calling brew audit [path ...] is disabled' error

The correct approach is to tap the local directory and then audit by formula name.
Focus this PR on making macOS testing non-blocking in releases only.
macOS PR testing will be implemented in a separate feature branch.
@F-WRunTime F-WRunTime changed the title Add macOS testing to PR workflow and make release macOS testing non-blocking Skip macOS testing in release: Make macOS testing non-blocking Sep 12, 2025
@F-WRunTime F-WRunTime merged commit a693040 into develop Sep 13, 2025
18 of 48 checks passed
@F-WRunTime F-WRunTime deleted the hotfix/mac-release-failure branch September 13, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants