Update dependency: deps/haskell-backend_release#4933
Merged
automergerpr-permission-manager[bot] merged 8 commits intoJun 17, 2026
Merged
Conversation
… version v0.1.153
… version v0.1.154
ehildenb
approved these changes
Jun 16, 2026
The template's lean-toolchain was `stable`, so `lake build` in the generated project floated to the latest stable Lean. v4.31.0 added `ByteArray.decEq` to core, colliding with the template's own definition and breaking the klean/test_generate integration test. Pin to v4.30.0, the last stable before the conflict. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
@tothtamas28 pinging you to make you aware of the Lean version pinning. |
9f3b576
into
develop
20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also pins Lean toolchain for klean codegen.
CI integration test
klean/test_generatestarted failing independently of the haskell-backend bump: the klean template'slean-toolchainwas set tostable, solake buildin the generated project floated to the latest stable Lean. v4.31.0 addedByteArray.decEqto core, which collides with the definition the template emits (Prelude.lean:226), failing the build with`ByteArray.decEq` has already been declared. Pinned the template'slean-toolchaintoleanprover/lean4:v4.30.0(last stable before the conflict; verified locally that v4.29.1 and v4.30.0-rc2 compile the generatedByteArray.decEqcleanly).Follow-up (out of scope): the template still hand-rolls
ByteArray.decEq; to move to Lean ≥4.31 it should drop that and use core'sDecidableEq ByteArray.