Skip to content

Add CI step to sync K definition files from feature/p-token on version update#31

Closed
mariaKt wants to merge 4 commits intomasterfrom
mk/automate-p-token-update
Closed

Add CI step to sync K definition files from feature/p-token on version update#31
mariaKt wants to merge 4 commits intomasterfrom
mk/automate-p-token-update

Conversation

@mariaKt
Copy link
Copy Markdown
Contributor

@mariaKt mariaKt commented Apr 23, 2026

This PR adds a CI step to automatically sync K definition files from feature/p-token on kmir version update.

When the kmir dependency is bumped, the K definition files (p-token.md, spl-token.md, info.md) are copied from feature/p-token and the requires paths are adjusted for the kompass layout. This automates one part of the manual sync, any Python API changes still need to be handled manually.

This is temporary and can be removed easily once feature/p-token is retired and all updates happen directly in kompass, but I see no reason not simplify the process in the meantime.

Copy link
Copy Markdown
Contributor

@dkcumming dkcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this misses the intention of KMIR and Kompass moving forward. The idea from previous discussions was to not use the feature/p-token branch at all. At this point we are probably able to make the switch and should not ever be pushing to feature/p-token, so this update is redundant.

What would be the value in continuing to develop on feature/p-token after this point?

@mariaKt
Copy link
Copy Markdown
Contributor Author

mariaKt commented Apr 24, 2026

Closed, since the feature/p-token branch was a temporary solution.

@mariaKt mariaKt closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants