Add CI step to sync K definition files from feature/p-token on version update#31
Closed
Add CI step to sync K definition files from feature/p-token on version update#31
Conversation
dkcumming
reviewed
Apr 24, 2026
Contributor
dkcumming
left a comment
There was a problem hiding this comment.
I think this misses the intention of KMIR and Kompass moving forward. The idea from previous discussions was to not use the feature/p-token branch at all. At this point we are probably able to make the switch and should not ever be pushing to feature/p-token, so this update is redundant.
What would be the value in continuing to develop on feature/p-token after this point?
Contributor
Author
|
Closed, since the feature/p-token branch was a temporary solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CI step to automatically sync K definition files from feature/p-token on kmir version update.
When the kmir dependency is bumped, the K definition files (p-token.md, spl-token.md, info.md) are copied from feature/p-token and the requires paths are adjusted for the kompass layout. This automates one part of the manual sync, any Python API changes still need to be handled manually.
This is temporary and can be removed easily once feature/p-token is retired and all updates happen directly in kompass, but I see no reason not simplify the process in the meantime.