Fall back to prove TOML for RPC proof commands#1154
Open
peter941221 wants to merge 2 commits into
Open
Conversation
Author
|
@palinatolmach I tightened the regression coverage for #1134 and marked this ready for review. Validation on this branch:
I also checked uv run make test against a clean master clone. It hits the same existing pytest-xdist collection mismatch in src/tests/unit/test_natspec.py, so that failure is not introduced by this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1134
When
kontrol.tomlonly defines proof-time settings under[prove.<profile>], the RPC proof commands that accept--config-fileand--config-profileread no TOML settings at all.pyk.parse_toml_args(...)only loads[args.command], sosimplify-node,step-node,section-edge, andget-modelignore the generatedkontrol.tomllayout and the reproducer from #1134.This patch makes those commands load
[prove.<profile>]first and then overlay any command-specific TOML section on top. Command-local overrides still win when both sections exist.Tests cover:
[prove.default]for all four RPC proof commandsValidation:
uv run make checkuv run pytest src/tests/unit/test_toml_args.py -quv run make teststill fails on a cleanmasterclone with the same existingpytest-xdistcollection mismatch insrc/tests/unit/test_natspec.py, so this PR does not introduce that failure