Skip to content

Dedupe function selector rules#1074

Merged
ehildenb merged 2 commits intomasterfrom
dedupe-function-selector
Apr 22, 2026
Merged

Dedupe function selector rules#1074
ehildenb merged 2 commits intomasterfrom
dedupe-function-selector

Conversation

@ehildenb
Copy link
Copy Markdown
Member

@ehildenb ehildenb commented Apr 21, 2026

We currently have duplicated rules for function selector check, which makes maintaining them a bit more fragile/brittle. This deduplicates them by sequentializing the check.

In particular:

  • Introduce extra step #checkFunctionFilter(...) for creating cut-rules where we have function calls we want to inspect.
  • Update tests that now need to take extra steps to get to the same state.
  • Update test expected output where relevant.

In addition, this makes a minor update to the CLAUDE.md with more fine-grained information about how to run tests and update expected output autonomously.

ehildenb and others added 2 commits April 21, 2026 16:52
…nFilter

The termCallFunction/termCallFunctionFilter and termCallIntrinsic/
termCallIntrinsicFilter pairs were duplicate rules differing only in a

Replace each pair with a single merged rule that prepends a new
termCallFunctionFilterMatch (the cut-point) and termCallFunctionFilterNoMatch.
Update _prove.py to reference the new rule ID.

Update exec-smir test depths and all golden expected outputs to account for
the one extra K step added per function call dispatch.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ehildenb ehildenb marked this pull request as ready for review April 21, 2026 19:44
@ehildenb ehildenb requested review from dkcumming and mariaKt April 21, 2026 19:44
Copy link
Copy Markdown
Collaborator

@dkcumming dkcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehildenb ehildenb merged commit dcf9eff into master Apr 22, 2026
12 checks passed
@ehildenb ehildenb deleted the dedupe-function-selector branch April 22, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants