Adding logging and pruning and proof resumption#539
Merged
Conversation
jberthold
approved these changes
Apr 29, 2025
Collaborator
Author
|
@jberthold could you please do another review? There is some more functionality added |
ehildenb
reviewed
Apr 29, 2025
gtrepta
approved these changes
Apr 29, 2025
Contributor
gtrepta
left a comment
There was a problem hiding this comment.
Looks pretty reasonable.
There's an unfortunate case with kmir run --verbose where the logging for KPrint.kore_to_pretty causes the result configuration to be printed out an extra time. Just noting that for now, there's not really a trivial way to suppress that here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed verbosity and debug logging in the typical RV way. It is important to add the flag for verbosity in the right place, which is after the first kmir command, e.g.:
Also added the ability to prune and resume proofs for better debugging.
IN PARTICULAR:
--max-depthtokmir proveallows for many steps the prover will take between nodes--max-iterationstokmir proveallows to restrict the number of steps the prover can take in totalkmir provewill now check if the proof exists on disc, if it does it will use this instead of restarting. Use--reloadto force it to restart anyway.kmir prune --proof-dir <DIR> <proof-id> <node_id>is added to remove a node and subsequent nodes in the graph from the proof saved on disc.