Skip to content

Adding logging and pruning and proof resumption#539

Merged
dkcumming merged 11 commits into
masterfrom
dc/logging
Apr 29, 2025
Merged

Adding logging and pruning and proof resumption#539
dkcumming merged 11 commits into
masterfrom
dc/logging

Conversation

@dkcumming
Copy link
Copy Markdown
Collaborator

@dkcumming dkcumming commented Apr 29, 2025

Needed verbosity and debug logging in the typical RV way. It is important to add the flag for verbosity in the right place, which is after the first kmir command, e.g.:

poetry run -C kmir/ kmir run --verbose <FILE>
poetry run -C kmir/ kmir prove --verbose run <FILE>

Also added the ability to prune and resume proofs for better debugging.

IN PARTICULAR:

  • Option --max-depth to kmir prove allows for many steps the prover will take between nodes
  • Option --max-iterations to kmir prove allows to restrict the number of steps the prover can take in total
  • kmir prove will now check if the proof exists on disc, if it does it will use this instead of restarting. Use --reload to force it to restart anyway.
  • kmir prune --proof-dir <DIR> <proof-id> <node_id> is added to remove a node and subsequent nodes in the graph from the proof saved on disc.

@dkcumming dkcumming requested review from gtrepta and jberthold April 29, 2025 02:09
@dkcumming dkcumming self-assigned this Apr 29, 2025
@dkcumming dkcumming changed the title Adding logging Adding logging and pruning and proof resumption Apr 29, 2025
@dkcumming
Copy link
Copy Markdown
Collaborator Author

@jberthold could you please do another review? There is some more functionality added

@dkcumming dkcumming requested a review from jberthold April 29, 2025 04:15
Comment thread kmir/src/kmir/__main__.py
Copy link
Copy Markdown
Contributor

@gtrepta gtrepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty reasonable.

There's an unfortunate case with kmir run --verbose where the logging for KPrint.kore_to_pretty causes the result configuration to be printed out an extra time. Just noting that for now, there's not really a trivial way to suppress that here.

@dkcumming dkcumming merged commit 45e9c00 into master Apr 29, 2025
6 checks passed
@dkcumming dkcumming deleted the dc/logging branch April 29, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants