Docker tweaks#544
Merged
Merged
Conversation
Member
|
Overall this looks fine to me, but I don't know what this docker image is used for. So I'll approve, but if it's something you're not sure of you should maybe wait for Freeman's approval. |
ehildenb
approved these changes
Apr 30, 2025
40b86f0 to
acf0d60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few improvements to make the docker containers start faster (
fixuidgoes through loads of files and takes >3min to start - those were probably the CI problems with permissions that we observed when usingdocker exec)delete a large number of files that aren't needed to work with the docker image
relocate
rustupinstallation out of/home/kmironly run
fixuidon thekmirhome directorychange
RUNcommand to use json style (avoids warning messages from the plugin in CI)Before this, it took very long to start the container , now the start time is down to 9 seconds on my machine.
We could try to not
chmodin$HOME/.cache(where a lot of files from the K definition are sitting) but that might break the run.