Skip to content

Docker tweaks#544

Merged
automergerpr-permission-manager[bot] merged 11 commits into
masterfrom
docker-tweaks
Apr 30, 2025
Merged

Docker tweaks#544
automergerpr-permission-manager[bot] merged 11 commits into
masterfrom
docker-tweaks

Conversation

@jberthold

@jberthold jberthold commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

A few improvements to make the docker containers start faster (fixuid goes through loads of files and takes >3min to start - those were probably the CI problems with permissions that we observed when using docker exec)

  • delete a large number of files that aren't needed to work with the docker image

  • relocate rustup installation out of /home/kmir

  • only run fixuid on the kmir home directory

  • change RUN command to use json style (avoids warning messages from the plugin in CI)

Before this, it took very long to start the container , now the start time is down to 9 seconds on my machine.
We could try to not chmod in $HOME/.cache (where a lot of files from the K definition are sitting) but that might break the run.

@jberthold jberthold requested a review from FWBlueWizard April 30, 2025 02:54
@jberthold jberthold marked this pull request as ready for review April 30, 2025 02:54
@jberthold jberthold requested a review from ehildenb April 30, 2025 03:02
@ehildenb

Copy link
Copy Markdown
Member

Overall this looks fine to me, but I don't know what this docker image is used for. So I'll approve, but if it's something you're not sure of you should maybe wait for Freeman's approval.

@automergerpr-permission-manager automergerpr-permission-manager Bot merged commit 2c79454 into master Apr 30, 2025
@automergerpr-permission-manager automergerpr-permission-manager Bot deleted the docker-tweaks branch April 30, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants