Skip to content

Refactor options classes and CLI args#548

Merged
dkcumming merged 8 commits into
masterfrom
refactor-options
May 1, 2025
Merged

Refactor options classes and CLI args#548
dkcumming merged 8 commits into
masterfrom
refactor-options

Conversation

@ehildenb

@ehildenb ehildenb commented May 1, 2025

Copy link
Copy Markdown
Member

This PR refactors the options classes and CLI args to deduplicate some things, and use the options classes directly when invoking the prover. In particular:

  • All the classes *Opts are moved out of __main__ and into options.
  • The function Prove.prove_rs(...) now takes a ProveRSOpts argument instead of all the individual arguments on their own.
  • We factor out a common ProveOpts class that ProveRunOpts and ProveRSOpts draw from instead of duplicating their entries.
  • We factor out a common prove_args CLI parser that prove_rs_args and prove_run_args pull from.
  • This also makes a small change where we make sure to update the kmir/uv.lock file on version bumps to keep that from happening locally afterward.

@ehildenb ehildenb self-assigned this May 1, 2025

@dkcumming dkcumming left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@dkcumming dkcumming marked this pull request as ready for review May 1, 2025 00:36
@dkcumming dkcumming merged commit 0935d9f into master May 1, 2025
6 checks passed
@dkcumming dkcumming deleted the refactor-options branch May 1, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants