Skip to content

Inline Tools class into KMIR and replumb#549

Merged
ehildenb merged 11 commits into
masterfrom
tools-inline
May 1, 2025
Merged

Inline Tools class into KMIR and replumb#549
ehildenb merged 11 commits into
masterfrom
tools-inline

Conversation

@ehildenb

@ehildenb ehildenb commented May 1, 2025

Copy link
Copy Markdown
Member

In preparation of building LHSs of specs directly, I've inlined the Tools class directly into the KMIR class, and propagated all the appropriate changes through.

This also required getting KParse to match the diamond import pattern of KRun and KProve (which I think is eventually the intention, to upstream it), so I did that as well.

Overall, this moves make_init_config and run_parsed directly into KMIR, so it's available for all commands that KMIR exposes.

As one minor build system improvement, I allow the user to set variable PARALLEL on the CLI when invoking make to spede things up.

@ehildenb ehildenb self-assigned this May 1, 2025
@ehildenb ehildenb changed the title Inline Tools class into KMIR and replump Inline Tools class into KMIR and replumb May 1, 2025
@ehildenb ehildenb marked this pull request as ready for review May 1, 2025 02:02
Comment thread kmir/src/kmir/__main__.py Outdated
Comment thread kmir/src/tests/integration/test_integration.py
@ehildenb

ehildenb commented May 1, 2025

Copy link
Copy Markdown
Member Author

Need to check that both versions of the tests (llvm and haskell) are being run for test_exec_smir.

@jberthold jberthold left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean-up!

@ehildenb ehildenb merged commit 5c284d9 into master May 1, 2025
6 checks passed
@ehildenb ehildenb deleted the tools-inline branch May 1, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants