Remove error rules for reading and writing locals#550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove error rules for reading and writing locals (type mismatch, moved and uninitialised values) which should not occur in valid MIR. These cases will now get stuck instead of producing an explained error.
We still match on the preconditions for valid list indexing and could remove that, too, but we still have to index into the locals so there is no big gain not doing that.
Remove errors related to type mismatch and operand mismatch in binary and unary operation rules. Likewise, these are invalid MIR code and the operation will get stuck now. Also removed: the case of unimplemented operations.
NB dynamic errors (overflow and division by zero) are still signalled as specific errors.