Update nix flake inputs structure and add rv-nix-tools to dependency update workflow#605
Closed
juliankuners wants to merge 3 commits into
Closed
Update nix flake inputs structure and add rv-nix-tools to dependency update workflow#605juliankuners wants to merge 3 commits into
rv-nix-tools to dependency update workflow#605juliankuners wants to merge 3 commits into
Conversation
17 tasks
jberthold
reviewed
May 27, 2025
Collaborator
There was a problem hiding this comment.
Thanks for looking into the nix setup.
However, this flake is currently unused, untested, and most likely broken anyway so we should probably not spend time on it until we want to un-break it anyway..
Contributor
Author
There was a problem hiding this comment.
Got it. Then I will cover this once I fix the nix flake entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adapts the nix flake inputs structure regarding
nixpkgsandrv-nix-tools. In particular,nixpkgsis now specified for inputs and transitive inputs by following an explicitly specified revision ofrv-nix-tools. More thorough reasoning for this change is outlined in documentation added by this PR runtimeverification/rv-nix-tools#14. This change is done to makenixpkgsproperly updatable by CI.In addition, this pull requests adapts the
update-deps.ymlworkflow to also updaterv-nix-toolsthat is used to implicitly specify the revision ofnixpkgs.