Merge changes into p-token#733
Closed
Stevengre wants to merge 4 commits into
Closed
Conversation
The [`bitRangeInt` equation in `domains.md`](https://github.com/runtimeverification/k/blob/c376de7d91e5f14cff13b7e32e1c997983a2859b/k-distribution/include/kframework/builtin/domains.md?plain=1#L1438) uses partial bit-shift symbols and is therefore not applied by booster. A better alternative is to use the `truncate` function locally defined in `mir-semantics`. Expressions are equivalent: ``` bitRangeInt(VAL, 0, WIDTH) (def) == (VAL >>Int 0) modInt (1 <<Int WIDTH) (>> 0) == VAL modInt (1 <<Int WIDTH) (mod via mask) == VAL &Int ((1<<Int WIDTH) -Int 1) == truncate(VAL, WIDTH, Unsigned) ``` Also marking some relevant simplifications as smt-lemmas. Altogether, this avoids a number of observed fall-backs in p-token execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.