This repository was archived by the owner on Oct 5, 2022. It is now read-only.
requested changes from commit after issue #5#8
Open
loopyd wants to merge 6 commits into
Open
Conversation
includes the hash argument as an option with affecting the url argument's functionality includes the error counter slight output cleanup - errors where being printed twice (unessecary), exception is now passed directly once to error() and printed optimally
Author
|
FYI, your change to use io.open instead of open produces the same error i was intending to fix in python 2.7 with my structural workarounds. be advised you will have to patch this. i left it intact to show you why this occours. (check travis) The correct method for 2.7, is: The python 3 syntax works and should be left as it is. Sorry there where two here, forgot the encoding specifier. |
Owner
|
Will start the review when build checks with Travis CI. |
Owner
|
Opening the file with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from issue #5:
--hash yesif you wish