HDR Dynamic Metadata Splitting#1151
Draft
superyu1337 wants to merge 4 commits into
Draft
Conversation
This is also supposed to fix the problem of scenes.json changing. We now rebuild the metadata chunks everytime and store it only internally, no serialization to scenes.json anymore.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1151 +/- ##
==========================================
- Coverage 62.00% 61.20% -0.80%
==========================================
Files 23 23
Lines 6416 6553 +137
==========================================
+ Hits 3978 4011 +33
- Misses 2438 2542 +104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HDR Dynamic Metadata splitting for both Dolby Vision RPUs and HDR10+ JSONs.
Related issue: #1005
Implementation
Adds two new parameters:
--dolby-vision-rpu <path>--hdr10plus-json <path>After running scene detection we load the RPU/JSON and split it.
This runs when creating the list
Sceneswhether that is by running scene detection or parsing an exisitingscenes.json.It does not introduce changes to scenes.json, but adds a new field in the internally used
Scenestruct.Todo
scenes.jsonis brokenIt could be that the deserialization is now incompatible withscenes.jsonfiles that don't include the new field.scenes.jsonare made after 7d40165Possible Todos