Skip to content

fix!: make the inner header pointer accessible again, although only though unsafe#504

Merged
johanneskoester merged 1 commit intorust-bio:masterfrom
jeeeesper:make-hdr-ptr-pub-again
Jan 29, 2026
Merged

fix!: make the inner header pointer accessible again, although only though unsafe#504
johanneskoester merged 1 commit intorust-bio:masterfrom
jeeeesper:make-hdr-ptr-pub-again

Conversation

@jeeeesper
Copy link
Copy Markdown
Contributor

See #502. A recent change prematurely changed visibility of some fields from pub to pub(crate), which was not desired. This change re-exposes these fields again, albeit not directly through field access but through an unsafe method. This is one way to solve the problem, the alternative would be to make the field public again.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 22, 2025

Pull Request Test Coverage Report for Build 20919353287

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • 66 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.03%) to 81.896%

Files with Coverage Reduction New Missed Lines %
src/bam/mod.rs 1 83.77%
src/bam/header.rs 2 81.36%
src/bam/ext.rs 3 91.88%
src/bcf/mod.rs 3 78.37%
src/bam/buffer.rs 4 53.85%
src/bcf/record.rs 4 82.54%
src/bcf/buffer.rs 5 62.32%
src/bam/record_serde.rs 12 82.12%
src/bam/record.rs 32 75.6%
Totals Coverage Status
Change from base Build 20368714287: 0.03%
Covered Lines: 2791
Relevant Lines: 3408

💛 - Coveralls

@jeeeesper jeeeesper force-pushed the make-hdr-ptr-pub-again branch from 706dabb to 478eb8b Compare January 12, 2026 11:39
@jeeeesper jeeeesper force-pushed the make-hdr-ptr-pub-again branch from 478eb8b to 0699c44 Compare January 12, 2026 12:27
@johanneskoester
Copy link
Copy Markdown
Contributor

Thanks, good idea!

@johanneskoester johanneskoester merged commit 4dc0fba into rust-bio:master Jan 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants