Merge #572: bitcoind: extract libexec/bitcoin-node and bin/bitcoin-cli alongside bitcoind

62f9f2b bitcoind: extract `libexec/bitcoin-node` and `bin/bitcoin-cli` alongside `bitcoind` (Толли)

Pull request description:

  The build script previously extracted only `bin/bitcoind` from the downloaded tarball and discarded the rest. Downstream crates that need `bin/bitcoin-cli` or since v30 -the multiprocess `libexec/bitcoin-node` had to maintain their own download + unpack logic, defeating the point of corepc's auto-download. sv2-apps is one such crate: it carries a manual download + extract + macOS codesigning block specifically to get at `libexec/bitcoin-node` for `-ipcbind=unix`.

  This PR extends the extraction filter to pull `bin/bitcoind`, `bin/bitcoin-cli`, and (when feature `30_0`+ is enabled) `libexec/bitcoin-node` from the `.tar.gz`. The cache-completeness check and the macOS arm64 ad-hoc signing pass are updated to match.

    Closes #566

    ## Tested

    - `cargo build --features "30_2 download"` from a clean cache: all three binaries on disk, all `codesign -v` pass, `bitcoin-node -regtest -ipcbind=unix` creates `regtest/node.sock`.
    - `cargo build --features "23_2 download"`: extracts `bitcoind` + `bitcoin-cli` only (no `libexec/bitcoin-node` in pre-v30 tarballs); rebuild cache-hits, no re-download loop.
    - Tarball layout verified identical across `bitcoin-30.2-x86_64-linux-gnu.tar.gz` and `bitcoin-30.2-arm64-apple-darwin.tar.gz`.

ACKs for top commit:
  tcharding:
    ACK 62f9f2b

Tree-SHA512: 51d7c9c83f90545da83b046f3c2b13e3c500ce113053e5450e2de7056578549e6551bf2f64bb40ba1613e2156ff02e168f364dd1c5500650defaec58a76ac891

Author: tcharding

bitcoind/build.rs

@@ -84,15 +84,23 @@ mod download {
         std::fs::create_dir_all(&bitcoin_exe_home)
             .with_context(|| format!("cannot create dir {:?}", bitcoin_exe_home))?;
 
-        let mut existing_filename =
-            bitcoin_exe_home.join(format!("bitcoin-{}", VERSION)).join("bin");
+        let version_dir = bitcoin_exe_home.join(format!("bitcoin-{}", VERSION));
+        let mut existing_filename = version_dir.join("bin");
         if cfg!(target_os = "windows") {
             existing_filename.push("bitcoind.exe");
         } else {
             existing_filename.push("bitcoind");
         }
 
-        if !existing_filename.exists() {
+        #[cfg(not(target_os = "windows"))]
+        let cache_complete = existing_filename.exists()
+            && version_dir.join("bin").join("bitcoin-cli").exists()
+            && (!cfg!(feature = "30_0")
+                || version_dir.join("libexec").join("bitcoin-node").exists());
+        #[cfg(target_os = "windows")]
+        let cache_complete = existing_filename.exists();
+
+        if !cache_complete {
             let download_filename = download_filename();
             println!("download_filename: {}", download_filename);
             let expected_hash = get_expected_sha256(&download_filename)?;
@@ -139,10 +147,15 @@ mod download {
             if download_filename.ends_with(".tar.gz") {
                 let d = GzDecoder::new(&tarball_bytes[..]);
 
+                let targets: &[&Path] = &[
+                    Path::new("bin/bitcoind"),
+                    Path::new("bin/bitcoin-cli"),
+                    Path::new("libexec/bitcoin-node"),
+                ];
                 let mut archive = Archive::new(d);
                 for mut entry in archive.entries().unwrap().flatten() {
                     if let Ok(file) = entry.path() {
-                        if file.ends_with("bitcoind") {
+                        if targets.iter().any(|t| file.ends_with(t)) {
                             entry.unpack_in(&bitcoin_exe_home).unwrap();
                         }
                     }
@@ -175,24 +188,31 @@ mod download {
             {
                 use std::process::Command;
 
-                let signing_status = Command::new("codesign")
-                    .arg("-v")
-                    .arg(&existing_filename)
-                    .status()
-                    .with_context(|| "failed to verify bitcoind code signature")?;
-
-                if !signing_status.success() {
-                    let status = Command::new("codesign")
-                        .arg("-s")
-                        .arg("-")
-                        .arg(&existing_filename)
-                        .status()
-                        .with_context(|| "failed to sign bitcoind")?;
-                    if !status.success() {
-                        return Err(anyhow::anyhow!(
-                            "codesign failed with exit code {}",
-                            status.code().unwrap_or(-1)
-                        ));
+                let to_sign = [
+                    version_dir.join("bin").join("bitcoind"),
+                    version_dir.join("bin").join("bitcoin-cli"),
+                    version_dir.join("libexec").join("bitcoin-node"),
+                ];
+                for binary in to_sign.iter().filter(|p| p.exists()) {
+                    let signing_status =
+                        Command::new("codesign").arg("-v").arg(binary).status().with_context(
+                            || format!("failed to verify code signature on {:?}", binary),
+                        )?;
+
+                    if !signing_status.success() {
+                        let status = Command::new("codesign")
+                            .arg("-s")
+                            .arg("-")
+                            .arg(binary)
+                            .status()
+                            .with_context(|| format!("failed to sign {:?}", binary))?;
+                        if !status.success() {
+                            return Err(anyhow::anyhow!(
+                                "codesign failed for {:?} with exit code {}",
+                                binary,
+                                status.code().unwrap_or(-1)
+                            ));
+                        }
                     }
                 }
             }