Merge #464: Update justfile to only build node and integration_test with the latest feature.

7607b0a update-lock-files with all or specific features (Jamil Lambert, PhD)
c2298f1 Add all-features and specific features to justfile (Jamil Lambert, PhD)
14a2a5a Add a latest feature to node integration_test (Jamil Lambert, PhD)

Pull request description:

  `node` and `integration_test` have individual features for each version of `bitcoind`. Enabling all at once makes no sense and caused a hang for a user when updating the lockfiles.

  - Add a `latest` feature that is set to the latest version of `bitcoind`
  - Update the justfile to build all crates except `node` and `integration_test` with `--all-features` and `node` and `integration_test` with only `latest`. Left as an array so that other features can be added if needed.
  - As above for the update lock files script.

  Closes #361

ACKs for top commit:
  tcharding:
    ACK 7607b0a

Tree-SHA512: 4a90523c0777aa1861151d1fb4a7b2d4e3dc2e968f05b929d9c66a2689ce2fe775a5a91eb6a88863c1d735a78a3de595276b956a0062cce51849e234d338b826

Author: tcharding

contrib/update-lock-files.sh

@@ -4,8 +4,27 @@
 
 set -euo pipefail
 
+REPO_DIR="$(git rev-parse --show-toplevel)"
+
+# Targets where `--all-features` is used.
+ALL_FEATURE_CRATES=(bitreq client fuzz jsonrpc types verify)
+
+# Targets with conflicting features and only speficic features are used.
+SPECIFIC_FEATURES_CRATES=(integration_test node)
+SPECIFIC_FEATURES=(latest)
+
+update_lock_files() {
+    for crate in "${ALL_FEATURE_CRATES[@]}"; do
+        cargo check --manifest-path "$REPO_DIR/$crate/Cargo.toml" --all-features
+    done
+
+    for crate in "${SPECIFIC_FEATURES_CRATES[@]}"; do
+        cargo check --manifest-path "$REPO_DIR/$crate/Cargo.toml" --no-default-features --features="${SPECIFIC_FEATURES[*]}"
+    done
+}
+
 for file in Cargo-minimal.lock Cargo-recent.lock; do
     cp --force "$file" Cargo.lock
-    cargo check --all-features
+    update_lock_files
     cp --force Cargo.lock "$file"
 done

integration_test/Cargo.toml

@@ -13,6 +13,8 @@ edition = "2021"
 [features]
 download = ["node/download"]
 
+latest = ["30_0"]
+
 # Enable the same feature in `node` and the version feature here.
 # All minor releases of the latest four versions.
 30_0 = ["v30_and_below", "node/30_0"]

justfile

@@ -2,6 +2,13 @@ set export
 
 REPO_DIR := `git rev-parse --show-toplevel`
 
+# Targets where `--all-features` is used.
+ALL_FEATURE_CRATES := "bitreq client fuzz jsonrpc types verify"
+
+# Targets with conflicting features and only `SPECIFIC_FEATURES` are used.
+SPECIFIC_FEATURES_CRATES := "integration_test node"
+SPECIFIC_FEATURES := "latest"
+
 alias ulf := update-lock-files
 alias l := lint
 alias li := lint-integration-tests
@@ -12,15 +19,21 @@ default:
 
 # Cargo build everything.
 build:
-  cargo build --workspace --all-targets --all-features
+  for crate in {{ALL_FEATURE_CRATES}}; do cargo build --manifest-path "$REPO_DIR/$crate/Cargo.toml" --all-targets --all-features; done
+
+  for crate in {{SPECIFIC_FEATURES_CRATES}}; do cargo build --manifest-path "$REPO_DIR/$crate/Cargo.toml" --all-targets --no-default-features --features={{SPECIFIC_FEATURES}}; done
 
 # Cargo check everything.
 check:
-  cargo check --workspace --all-targets --all-features
+  for crate in {{ALL_FEATURE_CRATES}}; do cargo check --manifest-path "$REPO_DIR/$crate/Cargo.toml" --all-targets --all-features; done
+
+  for crate in {{SPECIFIC_FEATURES_CRATES}}; do cargo check --manifest-path "$REPO_DIR/$crate/Cargo.toml" --all-targets --no-default-features --features={{SPECIFIC_FEATURES}}; done
 
 # Lint everything.
 lint: lint-verify lint-integration-tests
-  cargo +$(cat ./nightly-version) clippy --workspace --all-targets --all-features -- --deny warnings
+  for crate in {{ALL_FEATURE_CRATES}}; do cargo +$(cat ./nightly-version) clippy --manifest-path "$REPO_DIR/$crate/Cargo.toml" --all-targets --all-features -- --deny warnings; done
+
+  for crate in {{SPECIFIC_FEATURES_CRATES}}; do cargo +$(cat ./nightly-version) clippy --manifest-path "$REPO_DIR/$crate/Cargo.toml" --all-targets --no-default-features --features={{SPECIFIC_FEATURES}} -- --deny warnings; done
 
 lint-verify:
   $REPO_DIR/contrib/lint-verify.sh
@@ -40,7 +53,9 @@ format:
 
 # Generate documentation.
 docsrs *flags:
-  RUSTDOCFLAGS="--cfg docsrs -D warnings -D rustdoc::broken-intra-doc-links" cargo +$(cat ./nightly-version) doc --all-features {{flags}}
+  for crate in {{ALL_FEATURE_CRATES}}; do RUSTDOCFLAGS="--cfg docsrs -D warnings -D rustdoc::broken-intra-doc-links" cargo +$(cat ./nightly-version) doc --manifest-path "$REPO_DIR/$crate/Cargo.toml" --all-features {{flags}}; done
+
+  for crate in {{SPECIFIC_FEATURES_CRATES}}; do RUSTDOCFLAGS="--cfg docsrs -D warnings -D rustdoc::broken-intra-doc-links" cargo +$(cat ./nightly-version) doc --manifest-path "$REPO_DIR/$crate/Cargo.toml" --no-default-features --features={{SPECIFIC_FEATURES}} {{flags}}; done
 
 # Update the recent and minimal lock files.
 update-lock-files:

node/Cargo.toml

@@ -44,6 +44,8 @@ default = ["0_17_2"]
 
 download = ["anyhow", "bitcoin_hashes", "flate2", "tar", "bitreq", "zip"]
 
+latest = ["30_0"]
+
 # We support all minor releases of the latest four versions.
 30_0 = ["29_0"]
 29_0 = ["28_2"]