Skip to content

Bump rustls and related crates to latest versions#556

Merged
tcharding merged 1 commit intorust-bitcoin:masterfrom
tnull:2026-04-bump-rustls
Apr 19, 2026
Merged

Bump rustls and related crates to latest versions#556
tcharding merged 1 commit intorust-bitcoin:masterfrom
tnull:2026-04-bump-rustls

Conversation

@tnull
Copy link
Copy Markdown
Collaborator

@tnull tnull commented Apr 17, 2026

Fixes #553.
Alternative to #536, which also bumps rustls-webpki and other related crates.

Since there have recently been some advisories, we bump rustls and related crates such as rustls-webpki to latest versions.

@luisschwab
Copy link
Copy Markdown

You could add a cargo audit CI job here as well.

@luisschwab
Copy link
Copy Markdown

You need to alllow the duplicate deps on bitreq's Cargo.toml to fix linting

@tnull
Copy link
Copy Markdown
Collaborator Author

tnull commented Apr 17, 2026

You could add a cargo audit CI job here as well.

Eh, well, yes, see #557.

You need to alllow the duplicate deps on bitreq's Cargo.toml to fix linting

I'm aware, still trying to keep the duplicates minimal though, will update in abit.

@luisschwab
Copy link
Copy Markdown

luisschwab commented Apr 17, 2026

@tcharding if we could get new bitreq and electrsd releases after this is merged it would be great. Thanks.

Since there have recently been some advisories, we bump `rustls` and
related crates such as `rustls-webpki` to latest versions.
@tnull tnull force-pushed the 2026-04-bump-rustls branch from c39a671 to 9ddc66f Compare April 17, 2026 15:21
@tnull
Copy link
Copy Markdown
Collaborator Author

tnull commented Apr 17, 2026

Should be fixed now.

Copy link
Copy Markdown

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9ddc66f

@tcharding
Copy link
Copy Markdown
Member

@tcharding if we could get new bitreq and electrsd releases after this is merged it would be great. Thanks.

You mean electrsd because it depends on bitreq, right. If so we need jsonrpc and bitcoind to be released too. @jamillambert can you do a release tracking PR that does all those please bro? And I'll ack, merge, and publish.

Comment thread bitreq/Cargo.toml
rustls-native-certs = { version = "0.6.1", default-features = false, optional = true }
webpki-roots = { version = "0.25.2", default-features = false, optional = true }
rustls-webpki = { version = "0.101.0", default-features = false, optional = true }
rustls = { version = "0.23.38", default-features = false, features = ["ring", "std", "tls12"], optional = true }
Copy link
Copy Markdown
Member

@tcharding tcharding Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its weird to see std here (but I see its there in the serde_json dep too). I am surprised this doesn't break the no-std build. Both of these commands are clean, no clue why?

  • cargo test --no-default-features --features=rustls
  • cargo test --no-default-features --features=json-using-serde

@luisschwab
Copy link
Copy Markdown

You mean electrsd because it depends on bitreq

Exactly. Yeah, jsonrpc will need it too since it's on the dep tree. BDK uses electrsd so we need a new release for CI to be green again.

@tcharding tcharding merged commit f179f05 into rust-bitcoin:master Apr 19, 2026
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump rustls/rustls-webpki

3 participants