Run verify --tests in CI#644
Open
jamillambert wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
I left in the existing |
satsfy
suggested changes
Jun 24, 2026
satsfy
left a comment
satsfy
left a comment
Contributor
There was a problem hiding this comment.
PR looking good aside from one CI difficulty.
jamillambert
force-pushed
the
0622-verify-tests-CI
branch
from
7ea4357 to
da9f017
Compare
satsfy
approved these changes
Jun 24, 2026
satsfy
left a comment
satsfy
left a comment
Contributor
There was a problem hiding this comment.
tACK da9f017
Ran the CI again, fails as expected now on the integration tests.
tcharding
reviewed
Jul 6, 2026
Member
|
Stoked to see this go in. Nice effort. |
Adding verify --tests to CI runs it on all versions. This highlighted 2 missed problems: submitpackage is untested for v26 - Add `UNTESTED` label to the types table. abortprivatebroadcast test did not check the model - Fix the test.
For every version integration_tests CI capture the output and run verify --tests with the output generated. Run in the same job as the tests since they are needed to generate the file.
jamillambert
force-pushed
the
0622-verify-tests-CI
branch
from
da9f017 to
0b63ee8
Compare
Collaborator
Author
|
Suggested change made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the two problems highlighted when adding
verify --teststo CI:submitpackageis untested for v26 - AddUNTESTEDlabel to the types table.abortprivatebroadcasttest did not check the model - Fix the test.Add
verify --teststo CI:For every version
integration_testscapture the output and runverify --testswith the output generated. Run in the same job as the tests since they are needed to generate the file.Closes #639