Merge rust-bitcoin/rust-bitcoin-maintainer-tools#108: cargo-rbmt: disable api by default

f640aab cargo-rbmt: disable api by default (Nick Johnson)

Pull request description:

  Feedback from rust-bitcoin/rust-psbt#82, I think API checking should be an opt-in thing.

ACKs for top commit:
  tcharding:
    ACK f640aab

Tree-SHA512: c8d0ae44578ae28925f30e148266122e7fe957c1fb901e7598318052179c80f469b6a93eb6ee0057b5da02193dd281aea6389f40db5f5b7a646bd687f84c64fd

Author: tcharding

cargo-rbmt/src/api.rs

@@ -23,19 +23,15 @@ const RUSTDOCFLAGS_ALLOW_BROKEN_LINKS: &str = "-A rustdoc::broken_intra_doc_link
 type PackageApis = HashMap<FeatureConfig, public_api::PublicApi>;
 
 /// API-specific configuration, read from `[package.metadata.rbmt.api]` in `Cargo.toml`.
-#[derive(Debug, serde::Deserialize)]
+#[derive(Debug, Default, serde::Deserialize)]
 #[serde(default)]
 struct ApiConfig {
-    /// Whether to run API checks for this package. Defaults to `true`.
+    /// Whether to run API checks for this package. Defaults to `false`.
     enabled: bool,
     /// Feature combinations to test (in addition to no-features and all-features).
     features: Vec<Vec<String>>,
 }
 
-impl Default for ApiConfig {
-    fn default() -> Self { Self { enabled: true, features: Vec::new() } }
-}
-
 impl ApiConfig {
     /// Load API configuration from `[package.metadata.rbmt.api]` in the package's `Cargo.toml`.
     fn load(package_dir: &Path) -> Result<Self, Box<dyn std::error::Error>> {