Add generate block command

[benthecarman]

No description provided.

[andrewtoth]

This RPC takes bothTxids and RawTxs. We should support both I think. Perhaps by making it take a new enum that is either a RawTx or Txid?

[andrewtoth]

Also dupe of #189. Not sure if that author is still active though.

[benthecarman]

This RPC takes bothTxids and RawTxs. We should support both I think. Perhaps by making it take a new enum that is either a RawTx or Txid?

done

[apoelstra]

Thanks @benthecarman! concept ACK from me. I have a mild preference that the enum have a more generateblock-specific name but I can't think of a good one.

Heads up that this does not compile on Rust 1.41, which is our MSRV. I've approved CI so you should see a failure soon but here is the error on my end:

error[E0277]: the trait bound `bitcoin::blockdata::transaction::Transaction: bitcoincore_rpc::client::RawTx` is not satisfied
   --> integration_test/src/main.rs:376:29
    |
376 |     cl.send_raw_transaction(tx).unwrap();
    |                             ^^ the trait `bitcoincore_rpc::client::RawTx` is not implemented for `bitcoin::blockdata::transaction::Transaction`
    |
    = help: the following implementations were found:
              <&'a bitcoin::blockdata::transaction::Transaction as bitcoincore_rpc::client::RawTx>

error: aborting due to previous error

[andrewtoth]

Actually this doesn't have to be a Transaction but a RawTx trait object.

[benthecarman]

This doesn't really work, have to make it a Box<dyn RawTx> but still run into errors with sizing

[andrewtoth]

Right, it would actually have to be a generic enum.

[andrewtoth]

Hmm actually maybe not...

[benthecarman]

Fixed the compile issue I believe

[apoelstra]

@benthecarman compilation is fixed, but I believe now this is going to fail because cargo fmt doesn't pass :)

[benthecarman]

@benthecarman compilation is fixed, but I believe now this is going to fail because cargo fmt doesn't pass :)

Ah yeah there we're some unrelated to my changes so I didn't fix

[apoelstra]

ACK badf7fc

[apoelstra]

What version of core was this introduced in? It looks like it's not present in 0.19 and 0.20, which we run integration tests against.

I'm not sure how we handle feature-gating new RPCs here. It's not really my crate..

[andrewtoth]

Version 0.21

[tcharding]

Do you have clock cycles for this PR @benthecarman? Otherwise I can pick it up, if I do it it will not get done till after next release.

FTR I'm attempting to do a quick-ish release then start working on the harder stuff (update crate to support latest Core version).

[benthecarman]

I am at bitcoin++ this week, if you want a fast release go ahead and take this over

[tcharding]

Ha! 'quick-ish release' I must have been on crack when I wrote that.