Skip to content
This repository was archived by the owner on Nov 25, 2025. It is now read-only.

Add submitpackage#302

Open
joostjager wants to merge 1 commit into
rust-bitcoin:masterfrom
joostjager:submitpackage
Open

Add submitpackage#302
joostjager wants to merge 1 commit into
rust-bitcoin:masterfrom
joostjager:submitpackage

Conversation

@joostjager

Copy link
Copy Markdown

No description provided.

@stevenroose stevenroose left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, just nits.

I can't find a reference for the submitpackage rpc.. Is there an MR that adds it?

Could you add an integration test as well?

Thanks!

Comment thread json/src/lib.rs Outdated
Comment thread json/src/lib.rs Outdated
Comment thread client/src/client.rs Outdated
@joostjager

Copy link
Copy Markdown
Author

I can't find a reference for the submitpackage rpc.. Is there an MR that adds it?

It was added in bitcoin/bitcoin#24836. Regtest only, but possibly enabled for all networks in 25.0.

@joostjager

joostjager commented May 15, 2023

Copy link
Copy Markdown
Author

Could you add an integration test as well?

Seems blocked on #297

@tcharding tcharding added this to the v0.20.0 milestone Apr 30, 2024
@jlest01 jlest01 mentioned this pull request Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants