This repository was archived by the owner on Nov 25, 2025. It is now read-only.
code optimisations and clippies fixes#325
Open
wthrajat wants to merge 2 commits into
Open
Conversation
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Member
|
Hi, thanks for the contribution! There are too many different things going on in each patch for me to easily review. Can you please split up the patches so they do one thing only. FWIW overall the changes look good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Rust 2018, we do not require to declare this in order to use the library.
Also fixes various clippies to optimise code for better and run
cargo fmt.