Linting isn't configured to work with `cargo rbmt` ATM

[tcharding]

And with 5 minutes playing on a Friday I couldn't get it working. Probably something to do with this repo having a workspace but also a src/ directory. I tried throwing "." in the members list to no avail.

To close this issue probably decide on what lints we want in this repo (@apoelstra) and then hack it up (anyone).

FYI, in my environment I have.

$ cargo rbmt version
0.3.0 (unknown)

[nyonson]

Dunno what is wrong, but I think you are on to something about cargo-rbmt probably getting tripped up by the workspace settings. The other repos using cargo-rbmt are either "virtual" workspaces like rust-bitcoin where there is no src in the root, or just a package without a workspace like rust-psbt. Hopefully this is an easy tweak in cargo-rbmt...

[nyonson]

Although just gave it a whirl locally and looks ok?

19:40:01 ~/grd/rust-miniscript > cargo rbmt lint   
Running lint task...
Linting workspace...
$ cargo --locked clippy --workspace --all-targets --all-features --keep-going -- -D warnings
  Downloaded getrandom v0.2.14
  Downloaded arrayvec v0.7.4
  Downloaded semver v1.0.22
  Downloaded serde_test v1.0.176
  Downloaded aho-corasick v0.7.20
  Downloaded proc-macro2 v1.0.81
  Downloaded regex v1.7.3
  Downloaded syn v2.0.56
  Downloaded serde_derive v1.0.199
  Downloaded serde v1.0.199
  Downloaded libc v0.2.154
  Downloaded miniscript v12.3.0
  Downloaded 12 crates (2.1MiB) in 0.42s
   Compiling proc-macro2 v1.0.81
   Compiling unicode-ident v1.0.12
   Compiling serde v1.0.199
   Compiling libc v0.2.154
    Checking cfg-if v1.0.0
   Compiling bitcoin-internals v0.3.0
    Checking arrayvec v0.7.4
   Compiling cc v1.0.28
    Checking bitcoin-io v0.1.1
    Checking ppv-lite86 v0.2.17
   Compiling hex_lit v0.1.1
   Compiling bitcoin v0.32.6
    Checking bech32 v0.11.0
    Checking base64 v0.21.7
    Checking hex-conservative v1.0.0
   Compiling memchr v2.5.0
   Compiling semver v1.0.22
   Compiling honggfuzz v0.5.56
    Checking regex-syntax v0.6.29
    Checking hex-conservative v0.2.1
    Checking rustc_version v0.4.0
   Compiling secp256k1-sys v0.10.0
    Checking aho-corasick v0.7.20
    Checking getrandom v0.2.14
    Checking rand_core v0.6.4
   Compiling quote v1.0.36
    Checking rand_chacha v0.3.1
   Compiling syn v2.0.56
    Checking rand v0.8.5
    Checking regex v1.7.3
   Compiling serde_derive v1.0.199
    Checking bitcoin_hashes v0.14.0
    Checking serde_test v1.0.176
    Checking bitcoin-units v0.1.0
    Checking base58ck v0.1.0
    Checking secp256k1 v0.29.0
    Checking miniscript v13.0.0 (/home/njohnson/grd/rust-miniscript)
    Checking miniscript v12.3.0
    Checking descriptor-fuzz v0.0.1 (/home/njohnson/grd/rust-miniscript/fuzz)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.18s
$ cargo --locked clippy --workspace --all-targets --keep-going -- -D warnings
   Compiling bitcoin-internals v0.3.0
   Compiling bitcoin v0.32.6
   Compiling serde v1.0.199
    Checking bitcoin_hashes v0.14.0
    Checking bitcoin-units v0.1.0
    Checking secp256k1 v0.29.0
    Checking base58ck v0.1.0
    Checking serde_test v1.0.176
    Checking miniscript v13.0.0 (/home/njohnson/grd/rust-miniscript)
    Checking miniscript v12.3.0
    Checking descriptor-fuzz v0.0.1 (/home/njohnson/grd/rust-miniscript/fuzz)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.66s
Running package-specific lints...
Found crates: descriptor-fuzz, miniscript
$ cargo --locked clippy --all-targets --no-default-features --keep-going -- -D warnings
   Compiling bitcoin v0.32.6
    Checking secp256k1 v0.29.0
    Checking miniscript v13.0.0 (/home/njohnson/grd/rust-miniscript)
    Checking miniscript v12.3.0
    Checking descriptor-fuzz v0.0.1 (/home/njohnson/grd/rust-miniscript/fuzz)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.40s
$ cargo --locked clippy --all-targets --no-default-features --keep-going -- -D warnings
    Checking miniscript v13.0.0 (/home/njohnson/grd/rust-miniscript)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.31s
Checking for duplicate dependencies...
  Downloaded memmap2 v0.9.4
  Downloaded 1 crate (32.0KiB) in 0.12s
No duplicate dependencies found
Checking for cross-package duplicate dependencies...
No cross-package duplicate dependencies found
Checking for deprecated clippy.toml MSRV settings...
No deprecated clippy.toml MSRV settings found
Lint task completed successfully
19:40:31 <24s> ~/grd/rust-miniscript > cargo rbmt version
0.3.0 (a5aab96)

[tcharding]

This is from the commit log in #944

    FTR this does not enable the lint because for some reason adding this
    to the manifest doesn't work.
    
    ```rust
    [workspace.lints.clippy]
    use_self = "warn"
    ```
    
    I tested this patch using
    
      `cargo +$(cat ./nightly-version ) clippy -- -D clippy::use-self`

To prove again, just now, I patched the manifest on master and I get no warnings.

[nyonson]

Oh I bet it has to do with [workspace.lints.clippy] rules not being auto inherited by the packages in a workspace. The package needs to opt in with:

[lints]
workspace = true

But that does look super weird in a this workspace layout.