Invert malleability test in best_tap_spend#846
Merged
Conversation
Member
|
Hah, I think you're correct. Nice find! Though unfortunate that this breaks no tests.. |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…best_tap_spend`
36349ba51bd4ae3f51cd3b4768e024da0a376935 Invert malleability test in `best_tap_spend` (Daniel Roberts)
Pull request description:
I *really* don't feel like I have enough context to be confident in this change, but at the same time this seems pretty obviously backwards to the best of my (currently lacking) knowledge.
ACKs for top commit:
apoelstra:
ACK 36349ba51bd4ae3f51cd3b4768e024da0a376935; successfully ran local tests
Tree-SHA512: 036a1d284f4014ff1c14b88685d148091d36ada5a6ce64dd552f0df26e762dc1f393a3436d0940d69ac68864c1f3f906a6f03a6a6b7b0ae2387e7a3d2ea29aaf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really don't feel like I have enough context to be confident in this change, but at the same time this seems pretty obviously backwards to the best of my (currently lacking) knowledge.