Fix hardened derivation path error handling in at_derivation_index#913
Merged
Conversation
trevarj
approved these changes
Mar 28, 2026
trevarj
left a comment
trevarj
left a comment
Contributor
There was a problem hiding this comment.
Looks correct. No reason to have expects when the DefiniteDescriptorKey::new returns the error.
Member
|
We merged a number of fixes related to this in #830 last July -- particular we changed the contract of However, in #830 we didn't fix this callsite, which was assuming the old logic, because I didn't realize that the function wasn't already covering all the possible error cases. So this looks good to me. Should be backported to 13.x and 12.x (will be slightly nontrivial I think because #830 was nontrivial) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #912