refactor: make Descriptor plan API available for generic Pk#929
refactor: make Descriptor plan API available for generic Pk#929trevarj wants to merge 2 commits intorust-bitcoin:masterfrom
Descriptor plan API available for generic Pk#929Conversation
669788d to
fe71f3e
Compare
|
In fe71f3e: Can you re-add the old name as a deprecated passthrough to the new name? |
fe71f3e to
685d59c
Compare
Done. Wasn't sure which version to use in |
|
In |
|
Either If you're really motivated you can use |
685d59c to
5041df3
Compare
|
Pushed with "TBD" there is another one floating in the code too, so we can change all 3 to 14.0.0 when the time comes. |
|
CI is failing because there's a non-whitelisted call to the deprecated method somewhere. |
- Migrate `plan` and `plan_mall` methods from `DefiniteDescriptorKey` to generic `Pk: MiniscriptKey + ToPublicKey`. - Made the `Plan` struct generic over `Pk` (excluding `update_psbt_input` since it needs descriptor key data).
These functions consume `self`, therefore they should be prefixed with `into_`. The old functions are now deprecated.
5041df3 to
b646120
Compare
Right...rebased onto master. There was a usage of |
|
@apoelstra I think CI needs to be re-run: |
Migrate
planandplan_mallmethods fromDefiniteDescriptorKeyto genericPk: MiniscriptKey + ToPublicKey.Made the
Planstruct generic overPk(excludingupdate_psbt_inputsinceit needs descriptor key data).
Adding this to same PR in a separate commit since it's trivial:
planandplan_mallto haveinto_prefixCloses #927 and #928