Implement MiniscriptKey for each variant of DescriptorPublicKey#938
Merged
Conversation
Member
|
Neat! Yeah, good idea. I think for |
Contributor
Author
I would prefer doing it in the next PR. I can take care of that if there are no objections, but if you want, I can do it here with the next commit. |
Member
|
@Velnbur I'd appreciate a new PR! If not, I will probably do it "eventually". |
apoelstra
added a commit
to ElementsProject/elements-miniscript
that referenced
this pull request
Jun 22, 2026
…licKey 2a852f2 Implement MiniscriptKey for each variant of DescriptorPublicKey (Velnbur) Pull request description: The same as rust-bitcoin/rust-miniscript#938 but for elements ACKs for top commit: apoelstra: ACK 2a852f2; successfully ran local tests Tree-SHA512: ddd2e15491eab0e1613543e3378fcd56ca02802af70870885c7be1e8955a45199a33966a31e16121f0449f63628694a32a8d045ae14f3e56c8a9744f7afa7f79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds ability to specify
SinglePub,DescriptorXKeyandDescriptorMultiXKeydirectly inDescriptorwithout usingenum DescriptorPublicKey.In one of the projects we're using only
DescriptorMultiXKeywith fixed structure, so matchingDescriptorPublicKeyis kind of a pain. This PR fixes that