CI: Tidy up#943
Open
tcharding wants to merge 5 commits into
Open
Conversation
This was written when I had no idea what I was talking about. The 20 job limit is per project so the readme is total bollocks. Delete the readme and all the comments about number of jobs.
A new LTS release of Ubuntu came out last month, lets use it.
Mirror `rust-bitcoin` and run the stable and msrv tests in a single job.
As done in `rust-bitcoin` combine the lint, docs, docsrs, and bench jobs into a single job.
As discussed recently running the test with the nightly toolchain does not really give us any additional coverage. We already lint and build docs with the nightly toolchain.
trevarj
reviewed
May 13, 2026
Contributor
|
Can we re-run CI here? |
Member
Author
|
I re-ran all jobs and 24 just cancelled immediately. Did not investigate further. |
trevarj
reviewed
Jun 9, 2026
| runs-on: ubuntu-latest | ||
| Stable: | ||
| name: Test - ${{ matrix.toolchain }} toolchain, ${{ matrix.dep }} deps | ||
| runs-on: ubuntu-26.04 |
Contributor
There was a problem hiding this comment.
I guess this isn't a supported runner yet and that's why the CI is failing immediately.
For the record, rust-bitcoin is using ubuntu-24.04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do some clean ups. Basically just mirror what we do in
rust-bitcoinnow.