chore: update windows-sys dependency to 0.61#276
chore: update windows-sys dependency to 0.61#276vthib wants to merge 2 commits intorust-cli:mainfrom vthib:update-windows-sys-0.61
Conversation
windows-sys 0.61 requires windows-link 0.2.1 which requires rustc 1.71
We're not doing an MSRV bump at this time which is why #272 is still open |
|
Can you elaborate on why a bump from 1.66 (released in december 2022) to 1.71 (released in july 2023) is not acceptable? What is the MSRV goal of this project, that is how long ago should a version have been released to be acceptable as a MSRV? |
|
I don't really have a solid policy atm. Looking at our top direct dependents We already excluded Winnow with the 1.66 bump. Other important deps include:
|
|
I think it would be really unfortunate if using windows-sys 0.61 was blocked on an MSRV bump. I opened #282 to describe why this matters and to propose allowing both 0.60 and 0.61 as long as anstream has MSRV < 1.71. |
Anstyle crates are the only dependencies that are still pulling the windows-sys 0.61 on my projects.
There is an existing PR for it by the renovate bot:
#272 , but I figured i'd provide a PR that should be pass the CI to be easily mergeable.
This update requires a bump of MSRV to 1.71