Merged
Conversation
…configs to be stored in xdg defaults
deg4uss3r
force-pushed
the
rth/introduce_xdg
branch
from
0d982cc to
45bfa32
Compare
|
I'll take a look at this tomorrow! Thanks for the PR. |
strega-nil
reviewed
May 26, 2025
strega-nil
left a comment
strega-nil
left a comment
There was a problem hiding this comment.
Additionally, I'm really uncomfortable with the idea that one would have a silent, seriously breaking change behind a flag that could get accidentally turned on by a dependency. It would be nice if we checked for both locations on macOS, and maybe had a way to select which method should be used by the downstream application (since, for example, GUI apps may want to put their non-user-editable configuration into ~/Library)
Zykino
previously approved these changes
Jul 23, 2025
Contributor
Zykino
left a comment
Zykino
left a comment
There was a problem hiding this comment.
I don’t really know how to review the code here. I don’t know the directory, even less etcetera crate. 😅 (Also a lot is happening IRL for me so, don’t block on me please :) )
deg4uss3r
force-pushed
the
rth/introduce_xdg
branch
2 times, most recently
from
e4b0c44 to
56833ed
Compare
deg4uss3r
force-pushed
the
rth/introduce_xdg
branch
from
56833ed to
d47fe4f
Compare
…Finally move the CI to use a single thread as the changing of the strategy is based on atomics and can fail if multiple threads are changing it at once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
directoriescrate in favor ofetcetera2.0.0$XDG_CONFIG_HOMEviaetceteraAppStrategyrulesrustfmtfrom version1.88Resolves #117