Decode CSD based on CSD_STRUCTURE, not card_type#248
Merged
Conversation
Member
|
Have you tested this on hardware? I’m not in a position to do that myself this week. |
Merged
via the queue into
rust-embedded-community:develop
with commit Jun 3, 2026
5232dc4
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of the CSD depends on the
CSD_STRUCTUREfield, not the physical layer of the card.Specifically, there are Standard Capacity SD cards that still support CMD8 (
SD2);csd::Csd::newalready handles this correctly by looking atCSD_STRUCTUREinstead.