perf: implement fill_contiguous#232
Merged
Merged
Conversation
eldruin
approved these changes
Jun 27, 2025
eldruin
left a comment
eldruin
left a comment
Member
There was a problem hiding this comment.
Sounds good to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A significant amount of CPU time was being spent filling rectangles in my application. I traced most of the problem to
set_pixelbeing somewhat slow for large rectangular areas.By implementing
fill_contiguousmuch of the bounds checking and control flow changes for rotation are lifted outside the hot path.Tested on STM32G0 with 0.96 128x64 OLED over I2C.