Reduce unnecessary chunking#236
Open
bugadani wants to merge 2 commits into
Open
Conversation
bugadani
force-pushed
the
contiguous
branch
4 times, most recently
from
5ec86f5 to
03a11e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for helping out with SSD1306 development! Please:
masterif you're not already up to dateCHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmton the project withcargo fmt --all- CI will not pass without this stepPR description
This PR sends contiguous buffers in one operation, instead of chunking it up in 8-pixel tall stripes. If you update the whole display, the underlying display driver can transfer the buffer much more efficiently - in my case, with a 128x64 display, the driver issues a single send_data call instead of 8.
Before (ignore the 8MHz, my logic analyser is too slow to sample the 40MHz clock so it's aliasing):
After