Clean up CI#197
Merged
Merged
Conversation
Moves the arch-specific asm blocks into their respective modules.
This was causing problems running aarch32-cpu tests on an Apple MacBook.
thejpster
force-pushed
the
clean-up-ci
branch
6 times, most recently
from
86b1790 to
8868bb5
Compare
Contributor
Author
|
So I don't love that the CI time has gone from about 5 minutes to about 7.5 minutes. But I am happier that CI always does all the targets in the just file, instead of duplicating the list. |
thejpster
force-pushed
the
clean-up-ci
branch
2 times, most recently
from
461fdf1 to
d5218be
Compare
Contributor
Author
|
OK, I now have the target list in the justfile instead of in both the justfile and the workflow file. I also let the QEMU jobs start ASAP, to cut down on overall runtime. |
- Now only the justfile has the list of targets to test - QEMU jobs can start earlier
adamgreig
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we always use the same nightly version for everything (but we sill also check MSRV and latest stable in CI, for the targets where we can do that)
includes #196