Bump MSRV to 1.93 and use asm-cfg#199
Merged
Merged
Conversation
Contributor
Author
|
I did this. |
thejpster
force-pushed
the
use-asm-cfg
branch
2 times, most recently
from
c83f80b to
1284f42
Compare
…ith cfg. Requires Rust 1.93 or higher.
adamgreig
approved these changes
Jul 5, 2026
Contributor
Author
|
@adamgreig did you conclude that raising the MSRV to 1.93 was a fair price to pay for the neater asssembly code? |
Member
|
Yep, absolutely. It's well within our MSRV promise and this crate is also much newer so the odds of it causing any problems seem very low compared to a more established crate with more potential for users of older Rust versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #197
Uses newly stablised asm-cfg to remove the
system_init!macro.I left the FPU save/restore macros, because they get used in a lot of places and the duplication didn't seem worth it.