Merge #74

74: Simplify cargo bins and reorganize functions in lib.rs r=therealprof a=ZeroErrors

## Added
- Added `--no-default-features` cargo argument support
- Added `--profile` argument to allow specifying the profile to build the target package with
- Added `--frozen`, `--locked`, `--offline` cargo argument support
- Added `-Z` argument to allow use of unstable cargo features

## Fixed
- Fixed `cargo build` running for `cargo profdata` when its not required
- Fixed `--features` not allowing multiple

## Changes
- Allowed  multiple levels of verbosity and verbose cargo output via `-vv` and `-vvv`
- Changed `src/bin/cargo-*.rs` to use `Tool::cargo_exec` similar to `Tool::rust_exec` used in `src/bin/rust-*.rs`
- Removed unneeded `Endian` enum and  `Context::rustc_cfg`
- In-lined `Context::tool`
- Moved code so `Context` is only retrieved for `Tool::Objdump` as that's currently the only use case for it, this reduces calls to `rustc_version::version_meta()` for all other tools
- Re-split `determine_artifact` and `run` by in-lining and then extracting `args`, `cargo_build` and `cargo_build_args` functions
- Organized args to be the same order as in `cargo --help` to allow for easier comparison
- Used [`cargo clippy`](https://github.com/rust-lang/rust-clippy) to find and cleanup some minor issues

---

Few changes packed together in this one, let me know if you would prefer for it to be broken down.

Pending review of this PR, I agree it may be time for a release 😃 

r? @therealprof


Co-authored-by: Zero <nick@zero.dev>

Author: bors[bot]

CHANGELOG.md

@@ -12,6 +12,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Added `--quiet` and `--color` arguments to be passed to `cargo build`
 - Added `--test` and `--bench` build arguments to allow targeting testing artifacts
 - Added `--package` argument so its possible to specify a target package in a workspace
+- Added `--no-default-features` cargo argument support
+- Added `--profile` argument to allow specifying the profile to build the target package with
+- Added `--frozen`, `--locked`, `--offline` cargo argument support
+- Added `-Z` argument to allow use of unstable cargo features
 
 ### Fixed
 
@@ -21,13 +25,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Fixed panic due to broken pipe, caused by `bail!` while `cargo build` is running.
   Additionally fixes broken output format due to interrupted stderr output from `cargo build`
 - Fixed `rust-*` binaries exiting with exit code 0 if the tool was not found
+- Fixed `cargo build` running for `cargo profdata` when its not required
+- Fixed `--features` not allowing multiple
 
 ### Changed
 
 - Changed help output to more closely reflect the help command of `cargo` subcommands
 - Removed `walkdir` dependency by using expected path to tool executable
 - Updated `cargo_metadata 0.9 -> 0.10`
 - Replaced `failure` dependency with [`anyhow`](https://github.com/dtolnay/anyhow)
+- Allowed  multiple levels of verbosity and verbose cargo output via `-vv` and `-vvv`
 
 ## [v0.2.0] - 2020-04-11
 

src/bin/cargo-nm.rs

@@ -1,7 +1,3 @@
-use std::process;
-
-use cargo_binutils::Tool;
-
 const EXAMPLES: &str = "
 
 EXAMPLES
@@ -10,8 +6,5 @@ EXAMPLES
 `cargo nm --lib -- -print-size -size-sort` - lists all symbols sorted by size (smallest first)";
 
 fn main() {
-    match cargo_binutils::run(Tool::Nm, Some(EXAMPLES)) {
-        Err(e) => eprintln!("error: {}", e),
-        Ok(ec) => process::exit(ec),
-    }
+    cargo_binutils::Tool::Nm.cargo_exec(Some(EXAMPLES))
 }

src/bin/cargo-objcopy.rs

@@ -1,16 +1,9 @@
-use std::process;
-
-use cargo_binutils::Tool;
-
 const EXAMPLES: &str = "
 
 EXAMPLES
 
 `cargo objcopy --bin foo -- -O binary foo.hex`  - converts the output (e.g. ELF) into binary format";
 
 fn main() {
-    match cargo_binutils::run(Tool::Objcopy, Some(EXAMPLES)) {
-        Err(e) => eprintln!("error: {}", e),
-        Ok(ec) => process::exit(ec),
-    }
+    cargo_binutils::Tool::Objcopy.cargo_exec(Some(EXAMPLES))
 }

src/bin/cargo-objdump.rs

@@ -1,7 +1,3 @@
-use std::process;
-
-use cargo_binutils::Tool;
-
 const EXAMPLES: &str = "
 
 EXAMPLES
@@ -10,8 +6,5 @@ EXAMPLES
 `cargo objdump --bin foo --release -- -s -j .rodata`    - prints the contents of the .rodata section";
 
 fn main() {
-    match cargo_binutils::run(Tool::Objdump, Some(EXAMPLES)) {
-        Err(e) => eprintln!("error: {}", e),
-        Ok(ec) => process::exit(ec),
-    }
+    cargo_binutils::Tool::Objdump.cargo_exec(Some(EXAMPLES))
 }

src/bin/cargo-profdata.rs

@@ -1,10 +1,3 @@
-use std::process;
-
-use cargo_binutils::Tool;
-
 fn main() {
-    match cargo_binutils::run(Tool::Profdata, None) {
-        Err(e) => eprintln!("error: {}", e),
-        Ok(ec) => process::exit(ec),
-    }
+    cargo_binutils::Tool::Profdata.cargo_exec(None)
 }

src/bin/cargo-readobj.rs

@@ -1,7 +1,3 @@
-use std::process;
-
-use cargo_binutils::Tool;
-
 const EXAMPLES: &str = "
 
 EXAMPLES
@@ -10,8 +6,5 @@ EXAMPLES
 `cargo readobj --bin app -- -t` - Displays the symbol table";
 
 fn main() {
-    match cargo_binutils::run(Tool::Readobj, Some(EXAMPLES)) {
-        Err(e) => eprintln!("error: {}", e),
-        Ok(ec) => process::exit(ec),
-    }
+    cargo_binutils::Tool::Readobj.cargo_exec(Some(EXAMPLES))
 }

src/bin/cargo-size.rs

@@ -1,7 +1,3 @@
-use std::process;
-
-use cargo_binutils::Tool;
-
 const EXAMPLES: &str = "
 
 EXAMPLES
@@ -10,8 +6,5 @@ EXAMPLES
 `cargo size --bin foo --release -- -A`  - prints binary size in System V format";
 
 fn main() {
-    match cargo_binutils::run(Tool::Size, Some(EXAMPLES)) {
-        Err(e) => eprintln!("error: {}", e),
-        Ok(ec) => process::exit(ec),
-    }
+    cargo_binutils::Tool::Size.cargo_exec(Some(EXAMPLES))
 }

src/bin/cargo-strip.rs

@@ -1,16 +1,9 @@
-use std::process;
-
-use cargo_binutils::Tool;
-
 const EXAMPLES: &str = "
 
 EXAMPLES
 
 `cargo strip --bin foo --release -- -strip-all -o stripped`     - strips all symbols";
 
 fn main() {
-    match cargo_binutils::run(Tool::Strip, Some(EXAMPLES)) {
-        Err(e) => eprintln!("error: {}", e),
-        Ok(ec) => process::exit(ec),
-    }
+    cargo_binutils::Tool::Strip.cargo_exec(Some(EXAMPLES))
 }