Merge #72

72: Update Dependencies r=therealprof a=ZeroErrors

## Changes
- Updated `cargo_metadata`, `clap` and `regex` to their latest versions
- Replaced usage of deprecated `cargo_metadata` function with new function

## Description
`cargo_metadata` had a minor change in API which the code has been updated for.
`clap` has had a bug fix and improvement for building on windows. They also changed their minimum required rust to `1.36.0` however I have tested and still works on `1.38.0` which is `cargo-binutils` current minimum required rust.
`regex` has had no notable changes.

Co-authored-by: Zero <nick@zero.dev>

Author: bors[bot]

CHANGELOG.md

@@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 - Changed help output to more closely reflect the help command of `cargo` subcommands
 - Removed `walkdir` dependency by using expected path to tool executable
+- Updated `cargo_metadata 0.9 -> 0.10`
 
 ## [v0.2.0] - 2020-04-11
 

Cargo.toml

@@ -12,12 +12,12 @@ repository = "https://github.com/rust-embedded/cargo-binutils/"
 version = "0.2.0"
 
 [dependencies]
-cargo_metadata = "0.9.1"
-clap = "2.33.0"
-failure = "0.1.7"
-regex = "1.3.6"
-rustc-cfg = "0.4.0"
-rustc-demangle = "0.1.16"
-rustc_version = "0.2.3"
+cargo_metadata = "0.10"
+clap = "2.33"
+failure = "0.1"
+regex = "1.3"
+rustc-cfg = "0.4"
+rustc-demangle = "0.1"
+rustc_version = "0.2"
 serde = "1.0"
-toml = "0.5.6"
+toml = "0.5"

src/lib.rs

@@ -1,11 +1,11 @@
 #![deny(warnings)]
 
-use std::io::{self, Write};
+use std::io::{self, BufReader, Write};
 use std::path::{Component, Path};
 use std::process::{Command, Stdio};
 use std::{env, str};
 
-use cargo_metadata::{parse_messages, Artifact, CargoOpt, Message, Metadata, MetadataCommand};
+use cargo_metadata::{Artifact, CargoOpt, Message, Metadata, MetadataCommand};
 use clap::{App, AppSettings, Arg};
 use failure::bail;
 use rustc_cfg::Cfg;
@@ -241,10 +241,10 @@ fn determine_artifact(
     }
 
     let mut child = cargo.spawn()?;
-    let stdout = child.stdout.take().expect("Pipe to cargo process failed");
+    let stdout = BufReader::new(child.stdout.take().expect("Pipe to cargo process failed"));
 
     // Note: We call `collect` to ensure we don't block stdout which could prevent the process from exiting
-    let messages = parse_messages(stdout).collect::<Vec<_>>();
+    let messages = Message::parse_stream(stdout).collect::<Vec<_>>();
 
     let status = child.wait()?;
     if !status.success() {
@@ -255,7 +255,9 @@ fn determine_artifact(
     for message in messages {
         match message? {
             Message::CompilerArtifact(artifact) => {
-                if metadata.workspace_members.contains(&artifact.package_id) && build_type.matches(&artifact) {
+                if metadata.workspace_members.contains(&artifact.package_id)
+                    && build_type.matches(&artifact)
+                {
                     if wanted_artifact.is_some() {
                         bail!("Can only have one matching artifact but found several");
                     }
@@ -452,7 +454,7 @@ To see all the flags the proxied tool accepts run `cargo-{} -- -help`.{}",
 
         match tool {
             // Tools that don't need a build
-            Tool::Ar | Tool::Lld | Tool::Profdata => {},
+            Tool::Ar | Tool::Lld | Tool::Profdata => {}
             // for some tools we change the CWD (current working directory) and
             // make the artifact path relative. This makes the path that the
             // tool will print easier to read. e.g. `libfoo.rlib` instead of