Skip to content

do not query feature related args when they don't exist #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Emilgardis wants to merge 2 commits into from
Closed

do not query feature related args when they don't exist #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dec1b4
do not query feature related args when they don't exist
Emilgardis Aug 29, 2025
1027209
add regression check for #161
Emilgardis Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ jobs:
if: matrix.rust != 'stable'
run: cargo install --locked --path . -f

- name: run cargo-profdata --help
run: cargo profdata -- --help

- name: Run cargo-nm
run: cargo nm --bin cargo-nm -- --undefined-only

Expand Down
22 changes: 12 additions & 10 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,16 +280,18 @@ To see all the flags the proxied tool accepts run `cargo-{} -- --help`.{}",

pub fn run(tool: Tool, matches: ArgMatches) -> Result<i32> {
let mut metadata_command = MetadataCommand::new();
if let Some(features) = matches.get_many::<String>("features") {
metadata_command.features(CargoOpt::SomeFeatures(
features.map(|s| s.to_owned()).collect(),
));
}
if matches.get_flag("no-default-features") {
metadata_command.features(CargoOpt::NoDefaultFeatures);
}
if matches.get_flag("all-features") {
metadata_command.features(CargoOpt::AllFeatures);
if tool.needs_build() {
if let Some(features) = matches.get_many::<String>("features") {
metadata_command.features(CargoOpt::SomeFeatures(
features.map(|s| s.to_owned()).collect(),
));
}
if matches.get_flag("no-default-features") {
metadata_command.features(CargoOpt::NoDefaultFeatures);
}
if matches.get_flag("all-features") {
metadata_command.features(CargoOpt::AllFeatures);
}
}
if let Some(path) = matches.get_one::<String>("manifest-path") {
metadata_command.manifest_path(path);
Expand Down
Loading